Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12806

Use prepended js- hooks for all JS, rather than ones used in css

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 3.1.0-RC1
    • Fix Version/s: 3.1.0-RC6
    • Component/s: Styles
    • Labels:
      None

      Description

      Currently we hook our JS to IDs and classes that are not clearly defined as JS only reference hooks in the template files and thus css styles often get applied to them.

      We need to instead create js-hook_name reference for all the JS functionality and move all the css off the current Js hooks to better suited selectors

      EXP:
      <li id="quick-links" class="small-icon responsive-menu dropdown-container<!-- IF not S_DISPLAY_QUICK_LINKS and not S_DISPLAY_SEARCH -> hidden<!- ENDIF -->" data-skip-responsive="true">
      <a href="#" class="responsive-menu-link dropdown-trigger">

      {L_QUICK_LINKS}

      </a>

      CSS and JS are reference several pieces of this code

        Attachments

          Activity

            People

            Assignee:
            nickvergessen Joas Schilling [X] (Inactive)
            Reporter:
            Hanakin Hanakin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: