Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12783

Remove require: phpbb/phpbb from Extensions composer.json files

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-RC1
    • Fix Version/s: 3.1.0-RC2
    • Component/s: Extensions
    • Labels:
      None

      Description

      We currently check require: phpbb/phpbb

      	public function validate_require_phpbb()
      	{
      		if (!isset($this->metadata['require']['phpbb/phpbb']))
      		{
      			return false;
      		}
       
      		return true;
      	}

      However this blocks using the composer.json file for dependencies of the extension, because no package phpbb/phpbb exists. (Also block stuff like using scrutinizer for code quality and other tools that check the deps)

      We should move that to the extra section as we did with the extensions display-name, so extensions can use dependencies correctly.

        Attachments

          Activity

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: