Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12752

Cron list tests fail on windows with ansi support

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b4
    • Fix Version/s: 3.1.0-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      E:\Develop\develop>phpBB\vendor\bin\phpunit.bat tests\console\cron\cron_list_tes
      t.php
      PHPUnit 4.1.0 by Sebastian Bergmann.
       
      Configuration read from E:\Develop\develop\phpunit.xml.dist
       
      .FFF
       
      Time: 234 ms, Memory: 6.00Mb
       
      There were 3 failures:
       
      1) phpbb_console_command_cron_list_test::test_only_ready
      Failed asserting that Binary String: 0x1b5b33326d5441534b535f52454144591b5b306d2
      0636f6d6d616e643120636f6d6d616e6432 contains "TASKS_READY command1 command2".
       
      E:\Develop\develop\tests\console\cron\cron_list_test.php:48
       
      2) phpbb_console_command_cron_list_test::test_only_not_ready
      Failed asserting that Binary String: 0x1b5b33326d5441534b535f4e4f545f52454144591
      b5b306d20636f6d6d616e643120636f6d6d616e6432 contains "TASKS_NOT_READY command1 c
      ommand2".
       
      E:\Develop\develop\tests\console\cron\cron_list_test.php:54
       
      3) phpbb_console_command_cron_list_test::test_both_ready
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
      -TASKS_READY command1 command2 TASKS_NOT_READY command3 command4
      +TASKS_READY command1 command2 TASKS_NOT_READY command3 command4
       
      E:\Develop\develop\tests\console\cron\cron_list_test.php:60

      <Nicofuma> the --no-ansi argument is set...
      <Nicofuma> we should use $this->command_tester->execute(array('command' => $this->command_name), array('decorated' => false)); instead

      This indeed fixes the issue

        Attachments

          Activity

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: