Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12742

Notifications duplicate code that requires an event

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b4
    • Fix Version/s: 3.1.0-RC3
    • Component/s: Events, Notification System
    • Labels:
      None

      Description

      		if (empty($users))
      		{
      			return array();
      		}
      		sort($users);
       
      		$auth_read = $this->auth->acl_get_list($users, 'f_read', $post['forum_id']);
       
      		if (empty($auth_read))
      		{
      			return array();
      		}
       
      		$notify_users = $this->check_user_notification_options($auth_read[$post['forum_id']]['f_read'], $options);

      duplicates over almost all the files.
      it should be moved to a sub method in the base class, so we can add an event there instead of having multiple events

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Marc Marc
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development