Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12740

Stop Using IDs as CSS selectors

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.2.0-dev
    • 3.1.0-RC1
    • Styles
    • None

    Description

      The practice of using IDs as selectors in the css is a serious resource problem. IDs are more strictly scoped then classes and as such do not allow for modularization as classes do. Further more they are more resource costly than classes.

      We need to replace all of the ids in the theme to use classes instead. Wether its all accomplished in this PR or in several separate ones I will leave up to discussion.

      For now I replaced the logo to be a class.

      Attachments

        Activity

          People

            nickvergessen Joas Schilling [X] (Inactive)
            Hanakin Michael Miday
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: