[PHPBB3-12698] Replace all instances of magic numbers with constants in javascript

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.1.0-b4
Fix Version/s: 3.1.3-RC1, 3.2.0-a1
Component/s: None
Labels:
None

Description

In the javascript code there are multiple instances where the so-called magic numbers are used to identify difference occurrences.
The objective is to replace all those occurrences with "constants" in the phpBB global object.

Attachments

Sub-Tasks

Progress

1.	Create the base object to allocate the keyboard keys		Closed	Unassigned
2.	Replace instances in the message textarea keydown callback		Unverified Fix	Andreas Fischer [X] (Inactive)

Activity

People

Assignee:: Unassigned

Reporter:: brunoais

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 13/Jun/14 10:14 AM

Updated:: 18/Jan/15 7:30 PM

Resolved:: 18/Jan/15 7:30 PM