Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12562

Prosilver has no max-width

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 3.0.12, 3.1.0-b3
          • Fix Version/s: 3.1.0-RC2
          • Component/s: Styles
          • Labels:
            None

            Description

            Check out [1] in a really wide browser (or dimensionstoolkit.com). Looks rubbish, needs a max-width

            [1]: https://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42807

              Activity

              Ascending order - Click to sort in descending order
              17 older comments
              Hide
              Permalink
              callumacrae Callum Macrae added a comment -

              This is possible the most developer-y conversation I have read, ever.

              Most people use 940px. 940px works. Let's use it.

              Show
              callumacrae Callum Macrae added a comment - This is possible the most developer-y conversation I have read, ever. Most people use 940px. 940px works. Let's use it.
              Hide
              Permalink
              PayBas PayBas [X] (Inactive) added a comment -

              @Callum Macrae: if anything, it would be 960px due to the rule of thirds

              Show
              PayBas PayBas [X] (Inactive) added a comment - @Callum Macrae: if anything, it would be 960px due to the rule of thirds
              Hide
              Permalink
              bantu Andreas Fischer added a comment -

              This needs more work. Just adding max-width is not enough. It does not work well because it creates a lot of white space. As such https://github.com/phpbb/phpbb/pull/2533 is going to be reverted for the next release and we should rethink a more complete solution, e.g. the screenshot actually shown in https://github.com/phpbb/phpbb/pull/2533#issue-34763344

              Show
              bantu Andreas Fischer added a comment - This needs more work. Just adding max-width is not enough. It does not work well because it creates a lot of white space. As such https://github.com/phpbb/phpbb/pull/2533 is going to be reverted for the next release and we should rethink a more complete solution, e.g. the screenshot actually shown in https://github.com/phpbb/phpbb/pull/2533#issue-34763344
              Hide
              Permalink
              VSE Matt Friedman added a comment - - edited

              Agree. This type of change should be for 3.2.

              Because phpBB is in beta now, so we should be focused on bug fixes, or it will never get released, or worse - released with rushed last-minute changes not properly discussed or ironed out. So-called improvements and design changes at this point should be staged on the 3.2 branch at this point, unless they are absolutely essential to 3.1.

              Show
              VSE Matt Friedman added a comment - - edited Agree. This type of change should be for 3.2. Because phpBB is in beta now, so we should be focused on bug fixes, or it will never get released, or worse - released with rushed last-minute changes not properly discussed or ironed out. So-called improvements and design changes at this point should be staged on the 3.2 branch at this point, unless they are absolutely essential to 3.1.
              Hide
              Permalink
              PayBas PayBas [X] (Inactive) added a comment -

              To be fair, the PR actually was exactly like the screenshot. But it was changed.

              See here for the original branch (before it was changed and squashed): https://github.com/PayBas/phpbb/commits/ticket/12562-maxwidth-orig

              Show
              PayBas PayBas [X] (Inactive) added a comment - To be fair, the PR actually was exactly like the screenshot. But it was changed. See here for the original branch (before it was changed and squashed): https://github.com/PayBas/phpbb/commits/ticket/12562-maxwidth-orig

                People

                • Assignee:
                  naderman Nils Adermann
                  Reporter:
                  callumacrae Callum Macrae
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development