Details
-
Type:
Bug
-
Status: Unverified Fix
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.1.0-dev, 3.1.0-b3
-
Fix Version/s: 3.1.0-b4
-
Component/s: None
-
Labels:None
-
GitHub Pull Request URL:
Description
The get_versions() function in the version_helper requires the version.json file to have both stable and unstable branch/objects.
https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/phpbb/version_helper.php#L250
This is fine for phpBB's usage. But if extensions want to use this functionality, the unstable branch should not be a requirement, so that support for more simple version.json files will be allowed, such as:
{
|
"stable": {
|
"**major.minor**": {
|
"current": "**version information given**",
|
"announcement": "https://www.phpbb.com/**link to announcement topic**",
|
"eol": null,
|
"security": **false|true**
|
}
|
}
|
}
|
Activity
It should not require that both exist. You should be able to have only stable or only unstable or both stable and unstable.
Is this just as simple as changing:
if (empty($info['stable']) || empty($info['unstable']))
|
to
if (empty($info['stable']) && empty($info['unstable']))
|
I think it should also allow unstable only