Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12536

Get Versions Should Not Require Both Stable and Unstable Branches

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev, 3.1.0-b3
    • Fix Version/s: 3.1.0-b4
    • Component/s: None
    • Labels:
      None

      Description

      The get_versions() function in the version_helper requires the version.json file to have both stable and unstable branch/objects.
      https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/phpbb/version_helper.php#L250

      This is fine for phpBB's usage. But if extensions want to use this functionality, the unstable branch should not be a requirement, so that support for more simple version.json files will be allowed, such as:

      {
          "stable": {
              "**major.minor**": {
                  "current": "**version information given**",
                  "announcement": "https://www.phpbb.com/**link to announcement topic**",
                  "eol": null,
                  "security": **false|true**
              }
          }
      }
      

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        I think it should also allow unstable only

        Show
        nickvergessen Joas Schilling added a comment - I think it should also allow unstable only
        Hide
        VSE Matt Friedman added a comment - - edited

        It should not require that both exist. You should be able to have only stable or only unstable or both stable and unstable.

        Show
        VSE Matt Friedman added a comment - - edited It should not require that both exist. You should be able to have only stable or only unstable or both stable and unstable.
        Hide
        VSE Matt Friedman added a comment - - edited

        Is this just as simple as changing:

        if (empty($info['stable']) || empty($info['unstable']))

        to

        if (empty($info['stable']) && empty($info['unstable']))

        Show
        VSE Matt Friedman added a comment - - edited Is this just as simple as changing: if (empty($info['stable']) || empty($info['unstable'])) to if (empty($info['stable']) && empty($info['unstable']))
        Hide
        nicofuma nicofuma added a comment -

        indeed

        Show
        nicofuma nicofuma added a comment - indeed

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            VSE Matt Friedman
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development