Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12517

Missing argument in call to log.add() in prune_shadow_topics.php

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b3
    • Fix Version/s: 3.1.0-b4
    • Component/s: Build System
    • Labels:

      Description

      Read this detailed forum topic posted here before reporting it in tracker: http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45595

        Issue Links

          Activity

          Hide
          mrgtb mrgtb added a comment - - edited

          I made the file changes listed on two files, when uploading the changed files, the forum wouldn't even load a page (showed a white page for index) and generated an error.log on server. Did edits a second time again to files, just in case a mistake was made first time, also removed files in "cache folder" this time as well. But same thing, white blank page showed for forum homepage and error log generated again in root.

          So don't know if making the edits on two files and then uploading them should have fixed this or not? But for me running Beta 3, you can't even load the forum after making these edits on two files and replacing the ones on server with them for forum.

          Show
          mrgtb mrgtb added a comment - - edited I made the file changes listed on two files, when uploading the changed files, the forum wouldn't even load a page (showed a white page for index) and generated an error.log on server. Did edits a second time again to files, just in case a mistake was made first time, also removed files in "cache folder" this time as well. But same thing, white blank page showed for forum homepage and error log generated again in root. So don't know if making the edits on two files and then uploading them should have fixed this or not? But for me running Beta 3, you can't even load the forum after making these edits on two files and replacing the ones on server with them for forum.
          Hide
          prototech prototech added a comment -

          Post your edited files.

          Show
          prototech prototech added a comment - Post your edited files.
          Hide
          mrgtb mrgtb added a comment - - edited

          Here they are zipped, I just edited them again and tested for 3rd time, same result blank forum page and error log created on server.

          ERROR IN LOG:
          [12-May-2014 17:23:55 America/New_York] PHP Catchable fatal error: Argument 6 passed to phpbb\cron\task\core\prune_shadow_topics::__construct() must be an instance of phpbb\user, none given, called in /home/xxxxxxxx/public_html/cache/container_dotslash.php on line 826 and defined in /home/xxxxxxxxx/public_html/phpbb/cron/task/core/prune_shadow_topics.php on line 50

          Show
          mrgtb mrgtb added a comment - - edited Here they are zipped, I just edited them again and tested for 3rd time, same result blank forum page and error log created on server. ERROR IN LOG: [12-May-2014 17:23:55 America/New_York] PHP Catchable fatal error: Argument 6 passed to phpbb\cron\task\core\prune_shadow_topics::__construct() must be an instance of phpbb\user, none given, called in /home/xxxxxxxx/public_html/cache/container_dotslash.php on line 826 and defined in /home/xxxxxxxxx/public_html/phpbb/cron/task/core/prune_shadow_topics.php on line 50
          Hide
          mrgtb mrgtb added a comment -

          Just to add also, I've found out how to make this error happen. If you use moderator panel when viewing a thread and remove a guest posts using moderation page, it throws the error log on server and logged in Admin Cp

          Show
          mrgtb mrgtb added a comment - Just to add also, I've found out how to make this error happen. If you use moderator panel when viewing a thread and remove a guest posts using moderation page, it throws the error log on server and logged in Admin Cp
          Hide
          nicofuma nicofuma added a comment -

          in cront_tasks.yml, line 34 replace the tabs with spaces

          Show
          nicofuma nicofuma added a comment - in cront_tasks.yml, line 34 replace the tabs with spaces
          Hide
          mrgtb mrgtb added a comment - - edited

          On that line you said, I just deleted tabs before the entry on left "- @user" and then used spacebar to align it forward flush again with others listed above it (keep them all inline). That worked, but I never added any tabs before, I just pressed ENTER to create a new line to add the code and it auto aligned with others flush using NotePad++

          Anyway, at first it threw same error again, blank white page - but after removing all files generated in cache folder except for index.html and htaccess file (both in it by default). Now it works OK.

          Show
          mrgtb mrgtb added a comment - - edited On that line you said, I just deleted tabs before the entry on left "- @user" and then used spacebar to align it forward flush again with others listed above it (keep them all inline). That worked, but I never added any tabs before, I just pressed ENTER to create a new line to add the code and it auto aligned with others flush using NotePad++ Anyway, at first it threw same error again, blank white page - but after removing all files generated in cache folder except for index.html and htaccess file (both in it by default). Now it works OK.
          Hide
          Marc Marc added a comment -

          The files in the phpBB github repository do not contain any tabs. I just double-checked that.

          Show
          Marc Marc added a comment - The files in the phpBB github repository do not contain any tabs. I just double-checked that.

            People

            • Assignee:
              Marc Marc
              Reporter:
              mrgtb mrgtb
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development