Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12455

Remove unused strings EXTENSION_CONTROLLER_MISSING and EXTENSION_CLASS_WRONG_TYPE from common.php

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b2
    • Fix Version/s: 3.1.0-b3
    • Component/s: Language pack
    • Labels:

      Description

      The strings are not used and also contain wrong information:

      	'EXTENSION_CONTROLLER_MISSING'	=> 'The extension <strong>%s</strong> is missing a controller class and cannot be accessed through the front-end.',
      'EXTENSION_CLASS_WRONG_TYPE'	=> 'The extension controller class <strong>%s</strong> is not an instance of the phpbb_extension_controller_interface.',

      https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/language/en/common.php#L220-L221

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Same applies to the following strings in app.php

        'CONTROLLER_NOT_FOUND'				=> 'The requested page could not be found.',

        'CONTROLLER_SERVICE_NOT_GIVEN'		=> 'The controller "<strong>%s</strong>" must have a service specified in ./config/routing.yml.',

        'CONTROLLER_RETURN_TYPE_INVALID'	=> 'The controller object <strong>%s</strong> must return a Symfony\Component\HttpFoundation\Response object.',

        Show
        nickvergessen Joas Schilling added a comment - Same applies to the following strings in app.php 'CONTROLLER_NOT_FOUND' => 'The requested page could not be found.', 'CONTROLLER_SERVICE_NOT_GIVEN' => 'The controller "<strong>%s</strong>" must have a service specified in ./config/routing.yml.', 'CONTROLLER_RETURN_TYPE_INVALID' => 'The controller object <strong>%s</strong> must return a Symfony\Component\HttpFoundation\Response object.',

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development