Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12451

posting.php TOO_FEW_CHARS_LIMIT should be split for plurals

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b2
    • Fix Version/s: 3.1.0-b4
    • Component/s: Language pack
    • Labels:

      Description

      posting.php contains a string with 2 numbered placeholders that need plural forms. This is not immediately apparent from the English string, because it is phrased in a computery way. I recommend splitting this into 2 strings, and rephrasing the English string:

      Code: Select all
      'TOO_FEW_CHARS_LIMIT' => array(
      1 => 'Your message contains %1$d character. The minimum number of characters you need to enter is %2$d.',
      2 => 'Your message contains %1$d characters. The minimum number of characters you need to enter is %2$d.',
      ),

      My suggestion:

      Code: Select all
      'TOO_FEW_CHARS_CONTAINS' => array(
      1 => 'Your message contains %1$d character. %2$d',
      2 => 'Your message contains %1$d characters. %2$d',
      ),

      'TOO_FEW_CHARS_LIMIT' => array(
      1 => 'You need to enter at least %1$d character.',
      2 => 'You need to enter at least %1$d characters.',
      ),

      Then replace %2$d in TOO_FEW_CHARS_CONTAINS with TOO_FEW_CHARS_LIMIT

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nickvergessen Joas Schilling
                Reporter:
                GunChleoc GunChleoc
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: