Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12439

Unify behavior of sql_multi_insert for different dbms types

    XMLWordPrintable

Details

    • Improvement
    • Status: Unverified Fix (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.1.0-b2
    • 4.0.0-a1
    • None
    • None

    Description

      sql_multi_insert() accepts one-dimensional data (i.e. a single row), but only when the DBMS supports multi insert. This is obviously horrible API. There should be a method sql_insert() for single rows and sql_multi_insert() should only take multi-dimension arrays.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-12436 Functional test framework's add_style() should not use sql_multi_insert()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Marc Marc
              bantu Andreas Fischer [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: