Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12436

Functional test framework's add_style() should not use sql_multi_insert()

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.0-b2
    • 3.1.0-b3
    • Test Suite
    • None
    • SQLite2

    Description

      sql_multi_insert() is used by the functional test framework to add styles to the database. However, only one style is added at a time, so a multi-dimensional array is not passed in.
      https://github.com/phpbb/phpbb/blob/develop-ascraeus/tests/test_framework/phpbb_functional_test_case.php#L425

      The flip side of this question is, should the else clause of sql_multi_insert() allow for single dimension arrays to be passed in like it does for DBMSes that support multi-inserts?
      https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/phpbb/db/driver/driver.php#L514

      Attachments

        Issue Links

          Activity

            People

              bantu Andreas Fischer [X] (Inactive)
              Noxwizard Patrick Webster
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: