Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12436

Functional test framework's add_style() should not use sql_multi_insert()

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b2
    • Fix Version/s: 3.1.0-b3
    • Component/s: Test Suite
    • Labels:
      None
    • Environment:
      SQLite2

      Description

      sql_multi_insert() is used by the functional test framework to add styles to the database. However, only one style is added at a time, so a multi-dimensional array is not passed in.
      https://github.com/phpbb/phpbb/blob/develop-ascraeus/tests/test_framework/phpbb_functional_test_case.php#L425

      The flip side of this question is, should the else clause of sql_multi_insert() allow for single dimension arrays to be passed in like it does for DBMSes that support multi-inserts?
      https://github.com/phpbb/phpbb/blob/develop-ascraeus/phpBB/phpbb/db/driver/driver.php#L514

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          See PHPBB3-12439 for the proper fix.

          Show
          bantu Andreas Fischer added a comment - See PHPBB3-12439 for the proper fix.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Noxwizard Patrick Webster
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development