Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12399

Unnecessary filtering happens in MCP approval pages, in some, it's not even working correctly

    XMLWordPrintable

Details

    Description

      When creating a post (or topic) for approval, notifications should be created for forum moderators and administrators for them to approve it.
      There are two possible cases:

      1. When a post is sent for approval
      When clicking on this notification, it should lead you to the single post (or topic) approval page. But, when you instead choose to click on the menu's "Posts waiting for approval" it's filtering by the topic id in which the unapproved post was posted.
      So, you only see unapproved posts from that topic: Topics have been filtered to show only the one in which the unapproved post was created.
      Looking a bit into it, this happens because phpBB adds a &f=FID&t=TID (where TID is topic id and FID is forum id) to the menu's links, even if it isn't currently in the URL for the single-post approval (which should not be added).
      When adding a &p=PID (where PID is a random post id), no filtering happens, which is a bug.

      2. When a topic is sent for approval
      In this case, after clicking the notification to approve the topic and get into the single topic approval page, the same thing happens: Only posts for the unapproved topic appears (so, there appear no posts).
      This also happens because the &t=TID is filtering added to the link.
      But, there is an additional problem here: When a &t=TID (where TID is a random topic id) is added to the URL in the "Approve topics" page, if it does not correspond with any of the topics created it adds an option: "Only topic "TITLE", so it's not filtering correctly.
      ____________________

      Summary:
      1. When clicking to approve a topic or post, unnecessary (not needed) filtering happens by adding parameters to the GET URL (like &f=FID&t=TID&p=PID).
      2. Filtering is not working in the "Topics awaiting approval" page.

      Attachments

        Activity

          People

            Marc Marc
            marcosbc marcosbc [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: