Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12386

Add DEBUG_EXTRA again and use it for container creation

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b3
    • Component/s: Test Suite
    • Labels:
      None

      Description

      We are currently creating a new compiled container on every page load when having DEBUG enabled. However, one might only have that enabled to be presented with errors or for getting the page load stats.
      This does cause a major overhead which is especially noticeable in the functional tests. A small test showed that this might speed up functional tests by as much as 40 %.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          As a extension developer I really like this.
          It's quite painful to have 2-3 secs (1.5-2.5 is from container) loading time per page,
          just to be able to see debug messages.

          Show
          nickvergessen Joas Schilling added a comment - As a extension developer I really like this. It's quite painful to have 2-3 secs (1.5-2.5 is from container) loading time per page, just to be able to see debug messages.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          One of the reasons we got rid of debug extra was because nobody knew what exactly it did.

          Instead of using "DEBUG_EXTRA" please give it a more descriptive name.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - One of the reasons we got rid of debug extra was because nobody knew what exactly it did. Instead of using "DEBUG_EXTRA" please give it a more descriptive name.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Marc Marc
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development