Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12377

Move navbars to separate template files

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b2
    • Fix Version/s: 3.1.0-b3
    • Component/s: Styles
    • Labels:
      None

      Description

      Now that the template engine is much more powerful, I think many style developers will start to use template inheritance more and more. The overall_header.html is of course one of the most important.

      Would it be a good idea to move the <div class="navbar"> section to a new template file overall_header_navbar.html?

      It's gotten pretty big.

      Additionally, we could move the footer navbar as well (to overall_footer_navbar), for symmetry (as well as future expansions).

        Activity

        Hide
        wintstar wintstar added a comment -

        I think that this is not a good idea.

        Show
        wintstar wintstar added a comment - I think that this is not a good idea.
        Hide
        nickvergessen Joas Schilling added a comment -

        wintstar why would it be not a good idea?
        We break nothing, only add more power to styles that want to inherit prosilver, overwrite the header but keep the navbar the same. They currently need to fork the hole overall_header.html, which is now way less code

        Show
        nickvergessen Joas Schilling added a comment - wintstar why would it be not a good idea? We break nothing, only add more power to styles that want to inherit prosilver, overwrite the header but keep the navbar the same. They currently need to fork the hole overall_header.html, which is now way less code
        Hide
        wintstar wintstar added a comment -

        Still add an additional file. The more files are added, the building of the website will take longer. Even if it may be minimal.

        Show
        wintstar wintstar added a comment - Still add an additional file. The more files are added, the building of the website will take longer. Even if it may be minimal.
        Hide
        PayBas PayBas added a comment -

        I think that it will be very helpful for 90% of style authors, and the "longer loading" will only affect very big boards. And very big boards generally have the resources to change their templates to optimize them.

        Show
        PayBas PayBas added a comment - I think that it will be very helpful for 90% of style authors, and the "longer loading" will only affect very big boards. And very big boards generally have the resources to change their templates to optimize them.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            PayBas PayBas
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development