Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12352

The service definition "auth.provider.smf" does not exist.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-b2
    • Fix Version/s: 3.1.0-RC1
    • Component/s: Update system
    • Labels:
      None

      Description

      From using the automatic update package after using the smf converter at some point in the past:

      Fatal error: Uncaught exception 'Symfony\Component\DependencyInjection\Exception\InvalidArgumentException' with message 'The service definition "auth.provider.smf" does not exist.' in C:\xampp\htdocs\pcwebplus\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\ContainerBuilder.php:875 Stack trace:
      #0 C:\xampp\htdocs\pcwebplus\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\ContainerBuilder.php(483): Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition('auth.provider.s...')
      #1 C:\xampp\htdocs\pcwebplus\install\update\new\phpbb\session.php(579): Symfony\Component\DependencyInjection\ContainerBuilder->get('auth.provider.s...')
      #2 C:\xampp\htdocs\pcwebplus\install\update\new\phpbb\session.php(500): phpbb\session->session_create()
      #3 C:\xampp\htdocs\pcwebplus\install\install_update.php(120): phpbb\session->session_begin()
      #4 C:\xampp\htdocs\pcwebplus\install\index.php(386): install_update->main('update', 'intro')
      #5 C:\xampp\htdocs\pcwebplus\install\index.php(26 in C:\xampp\htdocs\pcwebplus\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\ContainerBuilder.php on line 875

      https://www.phpbb.com/community/viewtopic.php?f=466&t=2235881

      I'm not sure what would be best to fix this, but the error is going to confuse and upset users.

        Issue Links

          Activity

          Hide
          prototech prototech added a comment - - edited

          Yes, the majority of them do the same thing. As Nathan pointed out, it's necessary in order to be able to compare the passwords correctly.

          Show
          prototech prototech added a comment - - edited Yes, the majority of them do the same thing. As Nathan pointed out, it's necessary in order to be able to compare the passwords correctly.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Is this something we could fold into our own password system?

          One thing that could be done is, when a converter from another forum system is run, we copy all passwords over and prefix the passwords with some identifier (e.g. smf_*). Then our password system (core) will just match those to the particular comparison tool and use it. I'd assume there would be some way to detect them as well during the 3.0 to 3.1 update and add the correct prefix if it doesn't already have something.

          This would require we setup core password types for the systems we support conversions for (not many?), but that doesn't seem like a bad idea to me.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Is this something we could fold into our own password system? One thing that could be done is, when a converter from another forum system is run, we copy all passwords over and prefix the passwords with some identifier (e.g. smf_*). Then our password system (core) will just match those to the particular comparison tool and use it. I'd assume there would be some way to detect them as well during the 3.0 to 3.1 update and add the correct prefix if it doesn't already have something. This would require we setup core password types for the systems we support conversions for (not many?), but that doesn't seem like a bad idea to me.
          Hide
          Marc Marc added a comment -

          Prefixes should be in the format like $H$ or similar.We could add a passwords driver for the hash types and prefix them with the something like $S$. That should make it possible to convert them upon login. I'll try to look into this.

          Show
          Marc Marc added a comment - Prefixes should be in the format like $H$ or similar.We could add a passwords driver for the hash types and prefix them with the something like $S$. That should make it possible to convert them upon login. I'll try to look into this.
          Hide
          Marc Marc added a comment -
          Show
          Marc Marc added a comment - Issue doesn't seem to be fully fixed: https://www.phpbb.com/community/viewtopic.php?p=13775716#p13775776
          Hide
          Marc Marc added a comment -
          Show
          Marc Marc added a comment - See https://tracker.phpbb.com/browse/PHPBB3-13248 for new ticket

            People

            • Assignee:
              Marc Marc
              Reporter:
              EXreaction EXreaction [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development