Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12272

Hardcoded colon in subforums list

    Details

      Description

      In subforums list, under the parent forum description, it appears there is an harcoded colon. It doesn't affect moderators list. See the screenshot for more understanding.

      Here my proposed patch:

      OPEN: styles/prosilver/template/forumlist_body.html

      FIND:

      <br /><strong>{forumrow.L_SUBFORUM_STR}</strong>
      

      REPLACE WITH:

      <br /><strong>{forumrow.L_SUBFORUM_STR}{L_COLON}</strong>
      

      OPEN: includes/functions_display.php

      FIND:

      $l_subforums = (sizeof($subforums[$forum_id]) == 1) ? $user->lang['SUBFORUM'] . ': ' : $user->lang['SUBFORUMS'] . ': ';
      

      REPLACE WITH:

      $l_subforums = (sizeof($subforums[$forum_id]) == 1) ? $user->lang['SUBFORUM'] : $user->lang['SUBFORUMS'];
      

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Feel free to send a PR on github

        Show
        nickvergessen Joas Schilling added a comment - Feel free to send a PR on github
        Hide
        bantu Andreas Fischer added a comment -

        Issue confirmed.

        • The colon should be moved to the template
        • The template should use L_COLON
        • L_SUBFORUM_STR should use plurals instead of switching on SUBFORUM and SUBFORUMS?
        Show
        bantu Andreas Fischer added a comment - Issue confirmed. The colon should be moved to the template The template should use L_COLON L_SUBFORUM_STR should use plurals instead of switching on SUBFORUM and SUBFORUMS?
        Hide
        nickvergessen Joas Schilling added a comment -

        No, L_SUBFORUM_STR is fine as is. Plurals are only required when using it with a number.

        Show
        nickvergessen Joas Schilling added a comment - No, L_SUBFORUM_STR is fine as is. Plurals are only required when using it with a number.
        Hide
        bantu Andreas Fischer added a comment -

        Okay, I see.

        Show
        bantu Andreas Fischer added a comment - Okay, I see.
        Hide
        Maël Soucaze Maël Soucaze added a comment -

        PR sent.

        Show
        Maël Soucaze Maël Soucaze added a comment - PR sent.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            Maël Soucaze Maël Soucaze
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development