Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12258

Add attachment: error alert popup on "empty.png" does not show up

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-a3
    • Fix Version/s: 3.1.0-RC4
    • Component/s: JavaScript / AJAX, Posting
    • Labels:
      None
    • Environment:
      Firefox 27.0.1, Chrome 33.0, MySQL(i) 5.5.32, PHP Version 5.4.19

      Description

      When you add a attachment with 1.) a illegal extension or 2.) with a too big size, then a alert pops up and displays the reason.

      But if you add "empty.png" the error alert does not show up. Although a error-message appears when you try this with deactivated javascript.

      This should be the reason, why the travis-test does not get this error.

      So the ajax error alert has to be fixed.

        Activity

        Hide
        prototech prototech added a comment - - edited

        The Symfony DOM crawler does not support JS, so the Plupload uploader isn't what's causing the issue here. Throwing an error for this is also not simple. Plupload ignores 0-byte files, so the necessary event (FilesUploaded) in which to check the file size and throw an error will not fire.

        Show
        prototech prototech added a comment - - edited The Symfony DOM crawler does not support JS, so the Plupload uploader isn't what's causing the issue here. Throwing an error for this is also not simple. Plupload ignores 0-byte files, so the necessary event (FilesUploaded) in which to check the file size and throw an error will not fire.
        Hide
        prototech prototech added a comment -

        Plupload seems to allow 0-byte files now, so this is no longer an issue.

        Show
        prototech prototech added a comment - Plupload seems to allow 0-byte files now, so this is no longer an issue.

          People

          • Assignee:
            prototech prototech
            Reporter:
            Crizzo Crizzo
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development