Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12226

Incorrectly used plurals in ucp.php MOVE_PM_ERROR and FOLDER_MESSAGE_STATUS

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 3.1.0-a3
    • 3.1.0-b1
    • Language pack
    • None

    Description

      	'MOVE_PM_ERROR'					=> array(
      		2	=> 'An error occurred while moving the messages to the new folder, only %2d from %1d messages were moved.',
      	),

      we need to split this into 2 strings, because we need 2 different plurals:

      • %1d messages
      • and %2d ... were moved

      Broken example: An error occurred while moving the messages to the new folder, only 1 from 2 messages were moved.
      Should be: An error occurred while moving the messages to the new folder, only 1 from 2 messages was moved.

      Same for:

      	'FOLDER_MESSAGE_STATUS'		=> array(
      		1	=> '%2$d from %1$d message stored',
      		2	=> '%2$d from %1$d messages stored',
      	),

      Also shouldn't that be x out of y instead of x from y?

      (Blocker for B1)

      Attachments

        Activity

          People

            nickvergessen Joas Schilling
            nickvergessen Joas Schilling
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: