Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12198

Unused ERR_TEMPLATE_EVENT_* language strings in en/common.php

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-a3
    • Fix Version/s: 3.1.0-b2
    • Component/s: Language pack
    • Labels:

      Description

      in file en/common.php:

      'ERR_TEMPLATE_EVENT_LOCATION' => 'The specified template event location <em>[%s]</em> is improperly formatted.',

      I'm not sure what is improperly formatted. Is it location of event or event itself.

      I sent it first to the forum, but was told by Bantu to send it here.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        EXreaction [X] Do we even need this anymore? It was introduced to help events in the old template engine:
        https://github.com/phpbb/phpbb/commit/4ed9e4124e592ddb7fe2696e45261e74edb89ddd

        Show
        nickvergessen Joas Schilling added a comment - EXreaction [X] Do we even need this anymore? It was introduced to help events in the old template engine: https://github.com/phpbb/phpbb/commit/4ed9e4124e592ddb7fe2696e45261e74edb89ddd
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        My guess would be that Twig would have it's own error if an event was formatted wrong (or just not work). I don't think that language string is used anywhere.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - My guess would be that Twig would have it's own error if an event was formatted wrong (or just not work). I don't think that language string is used anywhere.
        Hide
        nickvergessen Joas Schilling added a comment -

        So ERR_TEMPLATE_EVENT_LOCATION and ERR_TEMPLATE_COMPILATION can be deleted

        Show
        nickvergessen Joas Schilling added a comment - So ERR_TEMPLATE_EVENT_LOCATION and ERR_TEMPLATE_COMPILATION can be deleted

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            leschek leschek
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development