Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12196

Referer vs Referrer in language files

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.12, 3.1.0-a3
    • Fix Version/s: 3.1.0-RC2
    • Component/s: Language pack
    • Labels:
      None

      Description

      In some files is used referer (with one R) - en/acp/board.php:

      'REFERER_VALID' => 'Validate Referer',

      'REFERER_VALID_EXPLAIN' => 'If enabled, the referer of POST requests will be checked against the host/script path settings. This may cause issues with boards using several domains and or external logins.',

      and in file en/acp/common.php:

      'LOG_REFERER_INVALID' => '<strong>Referer validation failed</strong><br />»Referer was “<em>%1$s</em>”. The request was rejected and the session killed.',

      In file en/acp/attachments.php is used referrer (with double R):

      'SECURE_EMPTY_REFERRER' => 'Allow empty referrer',

      'SECURE_EMPTY_REFERRER_EXPLAIN' => 'Secure downloads are based on referrers. Do you want to allow downloads for those omitting the referrer?',

      I guess it should be unified.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -

          "Referer" is not a word known to accepted dictionaries. This is for end user documentation, thus "Referrer" should be used.

          Show
          bantu Andreas Fischer added a comment - "Referer" is not a word known to accepted dictionaries. This is for end user documentation, thus "Referrer" should be used.
          Hide
          bantu Andreas Fischer added a comment -

          Both the language key and the language string should be fixed in 3.1.x as we do not want to change language keys in 3.0.x.

          Show
          bantu Andreas Fischer added a comment - Both the language key and the language string should be fixed in 3.1.x as we do not want to change language keys in 3.0.x.
          Hide
          bantu Andreas Fischer added a comment -

          It must be ensured that neither language strings nor language keys contain the word "referer".

          Show
          bantu Andreas Fischer added a comment - It must be ensured that neither language strings nor language keys contain the word "referer".

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              leschek leschek
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development