Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12191

UCP should open with global settings instead of notification settings

    Details

      Description

      in UCP board preferences edit notification settings is the start page..edit Global settings would make more sense.

      Just a small thing

        Activity

        Hide
        prototech prototech added a comment -

        Agreed.

        Show
        prototech prototech added a comment - Agreed.
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Is this on a new installation or on update?

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Is this on a new installation or on update?
        Hide
        Rotsblok Rikkert Westa [X] (Inactive) added a comment -

        new installation

        Show
        Rotsblok Rikkert Westa [X] (Inactive) added a comment - new installation
        Hide
        nickvergessen Joas Schilling added a comment -

        "Manage your external account associations" in UCP > Profile should be moved to the bottom aswell

        Show
        nickvergessen Joas Schilling added a comment - "Manage your external account associations" in UCP > Profile should be moved to the bottom aswell
        Hide
        aleha aleha added a comment -

        For new installations this can be fixed by moving notification settings 4 places down and external acc. associations 5 places down in install_install.php#L1652 and for b3 this can be fixed by a migrations file.

        If by any chance you plan to add more ucp options maybe this should be delayed otherwise I could create PR if that's ok with the reporter too. @Rikkert Westa

        PS: I can see this on a board of mine that started from a1 and now it's on b2.

        Show
        aleha aleha added a comment - For new installations this can be fixed by moving notification settings 4 places down and external acc. associations 5 places down in install_install.php#L1652 and for b3 this can be fixed by a migrations file. If by any chance you plan to add more ucp options maybe this should be delayed otherwise I could create PR if that's ok with the reporter too. @Rikkert Westa PS: I can see this on a board of mine that started from a1 and now it's on b2.
        Hide
        nickvergessen Joas Schilling added a comment -

        aleha just create a PR if we add more UCP modules later, we need to move it again.
        However I suggest to move it down only 1 module.

        Show
        nickvergessen Joas Schilling added a comment - aleha just create a PR if we add more UCP modules later, we need to move it again. However I suggest to move it down only 1 module.
        Hide
        aleha aleha added a comment -

        Specifically for notification settings in order to place it after global settings we have to consider two cases when updating a board:

        1. b2 => b3: Move notification settings 1 module down (the same goes for a new installation).
        2. 3.0.x => b3: Move notification settings 2 modules up. You can see on area51 that it is at the bottom.

        I plan on writing code for these two cases in the same migrations file, so please do correct me if I am wrong.

        Show
        aleha aleha added a comment - Specifically for notification settings in order to place it after global settings we have to consider two cases when updating a board: b2 => b3: Move notification settings 1 module down (the same goes for a new installation). 3.0.x => b3: Move notification settings 2 modules up. You can see on area51 that it is at the bottom. I plan on writing code for these two cases in the same migrations file, so please do correct me if I am wrong.
        Hide
        nickvergessen Joas Schilling added a comment -

        There is nothing wrong with having it at the bottom. I just don't like it to be on top. So I'd say lets just move it down by 4 on install. So just do something like https://github.com/nickvergessen/phpbb/commit/3d9b5aed46ac1c3aec4b3a068b837169748a429c

        Show
        nickvergessen Joas Schilling added a comment - There is nothing wrong with having it at the bottom. I just don't like it to be on top. So I'd say lets just move it down by 4 on install. So just do something like https://github.com/nickvergessen/phpbb/commit/3d9b5aed46ac1c3aec4b3a068b837169748a429c
        Hide
        Rotsblok Rikkert Westa [X] (Inactive) added a comment -

        Yup opens now nicely with the general board preferences

        Show
        Rotsblok Rikkert Westa [X] (Inactive) added a comment - Yup opens now nicely with the general board preferences

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            Rotsblok Rikkert Westa [X] (Inactive)
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development