Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12170

Migration helper replaces table name with 0 when creating tables

    Details

      Description

      The recently merged PR for splitting up schema changes in the migrator removes the table name that should be created in its method get_schema_steps() and replaces it with the array pointer. This causes queries like this:

      CREATE TABLE 0 ( some_column ...

      This breaks any extension or migration that uses the add_column method and possibly others.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          EXreaction can you fix this?

          Show
          nickvergessen Joas Schilling added a comment - EXreaction can you fix this?
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -
          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Fixed the test: https://github.com/phpbb/phpbb/pull/2013

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Marc Marc
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development