Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12162

Binary files missing from update packages

    XMLWordPrintable

Details

    Description

      When the OS locale is not set to C or en_US.UTF-8, the diff files will not be in english.
      Therefor

      			// Is binary?
      			if (preg_match('/^Binary files ' . $package_name . '\/(.*) and [a-z0-9._-]+\/\1 differ/i', $line, $match))
      			{
      				$binary[] = trim($match[1]);
      			}

      will not find the binary files and they are missing from the packages.

      We should set the locale for the diff command, so they are always english.

      Attachments

        Activity

          People

            nickvergessen Joas Schilling
            nickvergessen Joas Schilling
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: