Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12153

PAGE_NUMBER should be assigned by pagination.generate_template_pagination()

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b1
    • Component/s: Other
    • Labels:
      None

      Description

      This is currently being assigned separately in each file that uses the pagination classes which is redundant. The generate_template_pagination() method should be assigning it as is the case with all the other variables required by pagination.html

        Issue Links

          Activity

          Hide
          ErnadoO Erwan Nader added a comment -

          I have noticed a little display bug with this fix, on acp pagination:

          Replace the template var

          {S_ON_PAGE}

          with

          {PAGE_NUMBER}

          In acp/style/pagination.html can fix the problem

          Show
          ErnadoO Erwan Nader added a comment - I have noticed a little display bug with this fix, on acp pagination: Replace the template var {S_ON_PAGE} with {PAGE_NUMBER} In acp/style/pagination.html can fix the problem
          Hide
          prototech prototech added a comment -

          Thanks, fixed.

          Show
          prototech prototech added a comment - Thanks, fixed.

            People

            • Assignee:
              prototech prototech
              Reporter:
              prototech prototech
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development