Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12089

Make HTTP status code assertion failure messages more informative

    XMLWordPrintable

Details

    Description

      phpbb_functional_extension_controller_test::test_redirect
       
      Failed asserting that 503 matches expected 200.
       
      /home/travis/build/marc1706/phpbb/tests/test_framework/phpbb_functional_test_case.php:779
       
      /home/travis/build/marc1706/phpbb/tests/test_framework/phpbb_functional_test_case.php:738
       
      /home/travis/build/marc1706/phpbb/tests/test_framework/phpbb_functional_test_case.php:97
       
      /home/travis/build/marc1706/phpbb/tests/functional/extension_controller_test.php:122

      The error message should contain, that the numbers are the Status codes. Maybe we can also try to include the URL of the request, so it's easier to see the failing URL directly instead of digging through the code.

      Attachments

        Activity

          People

            nickvergessen Joas Schilling [X] (Inactive)
            nickvergessen Joas Schilling [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: