Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12016

Event listeners should be services

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 3.1.0-a1
    • 3.1.0-a2
    • Events
    • None

    Description

      They should either be provided from a provider, or we should check whether there is a service available for that class, instead of creating the instance ourselves.
      Current code:

      		foreach ($subscriber_classes as $class)
      		{
      			$subscriber = new $class();
      			$this->dispatcher->addSubscriber($subscriber);
      		}

      Attachments

        Activity

          People

            nickvergessen Joas Schilling [X] (Inactive)
            nickvergessen Joas Schilling [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: