Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12000

ACP: Banning IPs by range fails to ban all IPs in range

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Duplicate
    • 3.0.11, 3.0.12
    • 3.1.7-RC1
    • ACP
    • None
    • PHP Version 5.3.3-7+squeeze17, MySQL 5.1.72, Firefox 25.0 WinXPpro SP3

    Description

      When banning a range of IPs that should generate a "xxx.xxx.255.*" or "xxx.255.*.*" ban_ip database entry in phpbb_banlist the 255.* range is left out.

      Example: Banning 0.0.251.0-0.0.1.1 generates ban_ip entries of

       0.0.251.*, 0.0.252.*, 0.0.253.*, 0.0.254.*, 0.1.0.*, 0.1.1.0 

      0.0.255.* is missing.

      Also, though perhaps I should raise this separately, banning a range such as 0.0.0.0-0.0.0.255 generates 256 individual ban_ip entries rather than one using a wildcard i.e. 0.0.0.* This is why I would ban this range using 0.0.0.0-0.0.1.0 then un-ban 0.0.1.0

      Attachments

        1. functions_user.php
          99 kB
        2. functions_user_original.php
          96 kB
        3. diff.txt
          6 kB

        Issue Links

          Activity

            People

              Elsensee Oliver Schramm [X] (Inactive)
              petehorn petehorn [X] (Inactive)
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: