Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11857

Avatar manager must not depend on entire container

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a2
    • Labels:
      None

      Description

      Passing the container as an argument to a service defeats the purpose of dependency injection. Instead it should use a service collection to use tagged services to retrieve a set of drivers, and then pass this array into the manager. Look at cron for how this is implemented correctly.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            naderman Nils Adermann
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development