Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11843

Regression: using underscores in template DEFINE variables yields unexpected behavior

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Template Engine
    • Labels:
      None

      Description

      Since 'DEFINE.+=' was changed to 'DEFINE \$[a-zA-Z0-9]+ =', DEFINE variables with underscores in them are not processed by phpbb_template_twig_lexer::fix_inline_variable_tokens() anymore. Seeing how the stock template files use more DEFINE vars with underscores in them than without, I'd say this isn't intended behaviour .

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          Please also add unit tests for that

          Show
          nickvergessen Joas Schilling added a comment - Please also add unit tests for that

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              rechosen rechosen [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development