Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11832

URLs in tests aren't shortened, triggering errors in Composer files

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      Function request() in phpbb_functional_test_case.php merges root url with path but does not remove single and double dots from path. As a result when both root_url and path are set it results in URLs like this:

      http://localhost/phpBB/./index.php

      Symphony's HTTP client requests it like that without removing ./ from URLs and in result $_SERVER variable is different, confusing Request class... or something like that. I'm not sure which one of those components is causing error.

      Solution is to fix URLs before requesting it in test suite, avoiding that bug.

        Issue Links

          Activity

          Hide
          bantu Andreas Fischer added a comment -
          Show
          bantu Andreas Fischer added a comment - Patch was not acceptable. See https://github.com/phpbb/phpbb3/pull/1703#issuecomment-24113669
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Working on it

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Working on it
          Show
          EXreaction EXreaction [X] (Inactive) added a comment - PR: https://github.com/phpbb/phpbb3/pull/1706
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -
          Show
          EXreaction EXreaction [X] (Inactive) added a comment - First merged patch: https://github.com/phpbb/phpbb3/pull/1703

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              Arty Vjacheslav Trushkin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development