Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11825

phpBB/phpbb/ should only contain classes

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Other
    • Labels:
      None

      Description

      https://github.com/phpbb/phpbb3/pull/1694/files added an include file to the wrong directory.

      The db/schema_data.php should either be turned into a class, or moved to includes/

        Issue Links

          Activity

          Hide
          EXreaction EXreaction [X] (Inactive) added a comment - - edited

          There should be an RFC for this as we do not have coding guidelines on the organization of these directories. Once a decision is made as to what the proper organization should be, we should update the guidelines within this ticket if phpbb/ is only going to contain classes.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - - edited There should be an RFC for this as we do not have coding guidelines on the organization of these directories. Once a decision is made as to what the proper organization should be, we should update the guidelines within this ticket if phpbb/ is only going to contain classes.
          Hide
          nickvergessen Joas Schilling added a comment -

          No need for a RFC?
          The phpbb/ directory was created for classes so they are PSR-0 valid. All other files that do not contain autoloadable classes or functions only, are still in includes/ thats why we have that dir.

          Show
          nickvergessen Joas Schilling added a comment - No need for a RFC? The phpbb/ directory was created for classes so they are PSR-0 valid. All other files that do not contain autoloadable classes or functions only, are still in includes/ thats why we have that dir.

            People

            • Assignee:
              dhruv.goel92 Dhruv Goel
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development