Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11812

No longer able to define empty template variable using DEFINE

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Template Engine
    • Labels:
      None

      Description

      Until switching to twig, one was able to define an empty template variable, e.g.:

      <!-- DEFINE $FOOBAR = '' -->

      This no longer works and causes the following error message:

      Unexpected token "string" of value "" ("end of statement block" expected)

      Only this will currently work:

      <!-- DEFINE $FOOBAR = ' ' -->

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        How is this not a blocker, if it breaks BC on currently working code for no reason and should be a simple fix?

        Show
        nickvergessen Joas Schilling added a comment - How is this not a blocker, if it breaks BC on currently working code for no reason and should be a simple fix?
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        A blocker is something that's a critical issue and is not allowing at least the essential desired features to work as intended. This is neither a critical issue (it is not used in phpBB and has an easy work around), nor is it breaking essential features of phpBB. This certainly isn't blocking an alpha/preview release.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - A blocker is something that's a critical issue and is not allowing at least the essential desired features to work as intended. This is neither a critical issue (it is not used in phpBB and has an easy work around), nor is it breaking essential features of phpBB. This certainly isn't blocking an alpha/preview release.
        Hide
        bantu Andreas Fischer added a comment -

        This is possibly used by us.

        afischer@leonard:/var/www/projects/phpbb3 (develop) phpBB $ grep "<\!-- DEFINE" . -Ri | grep "= ''"
        ./styles/subsilver2/template/breadcrumbs.html:	<!-- IF $S_MICRODATA --><!-- DEFINE $MICRODATA = ' itemtype="http://data-vocabulary.org/Breadcrumb" itemscope=""' --><!-- ELSE --><!-- DEFINE $MICRODATA = '' --><!-- ENDIF -->

        Show
        bantu Andreas Fischer added a comment - This is possibly used by us. afischer@leonard:/var/www/projects/phpbb3 (develop) phpBB $ grep "<\!-- DEFINE" . -Ri | grep "= ''" ./styles/subsilver2/template/breadcrumbs.html: <!-- IF $S_MICRODATA --><!-- DEFINE $MICRODATA = ' itemtype="http://data-vocabulary.org/Breadcrumb" itemscope=""' --><!-- ELSE --><!-- DEFINE $MICRODATA = '' --><!-- ENDIF -->

          People

          • Assignee:
            EXreaction EXreaction [X] (Inactive)
            Reporter:
            Marc Marc
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development