Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11787

Permission language strings use samp for highlight instead of strong

          Details

          • Type: Bug
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.0.11, 3.1.0-dev
          • Fix Version/s: 3.1.0-b1
          • Component/s: Language pack
          • Labels:

            Description

            German version with strong ( Einstellung verfolgen_20130813-154647.png )
            English version with samp ( Trace permission_20130813-154356.png )

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              VSE Matt Friedman added a comment -

              Samp is being replaced with code in this PR: https://github.com/phpbb/phpbb/pull/2118

              German version (and other languages) should follow the English version and use code as well, instead of strong.

              Show
              VSE Matt Friedman added a comment - Samp is being replaced with code in this PR: https://github.com/phpbb/phpbb/pull/2118 German version (and other languages) should follow the English version and use code as well, instead of strong.
              Hide
              Permalink
              bantu Andreas Fischer added a comment - - edited

              I think, semantically, neither samp nor code is correct. These are neither code nor examples.
              Looking at the screenshot, I'd say that the strong version looks a lot better. Not sure how the code version looks.

              Also, for the record: The german translation team seems to have decided that it is better to use strong instead of stamp. This should have been reported upstream earlier in order to achieve consistency.

              Show
              bantu Andreas Fischer added a comment - - edited I think, semantically, neither samp nor code is correct. These are neither code nor examples. Looking at the screenshot, I'd say that the strong version looks a lot better. Not sure how the code version looks. Also, for the record: The german translation team seems to have decided that it is better to use strong instead of stamp. This should have been reported upstream earlier in order to achieve consistency.
              Hide
              Permalink
              Crizzo Crizzo added a comment - - edited

              <code> is for code
              <samp> is a sample output of a computer program.
              http://www.w3schools.com/tags/tag_samp.asp

              So replacing <samp> with <code> does not make sense. And on some points, it is just not needed because it is correctly there.

              But <strong> highlights the words YES and NO and NEVER. That is how it should work, because of the "accentuation" of these words. <em> would be okay too, but it is a weaker accentuation than <strong>.

              I added a PR which changes the permissions.php language file. But i think it should be nessesary to check i up allover phpBB.

              Show
              Crizzo Crizzo added a comment - - edited <code> is for code <samp> is a sample output of a computer program. http://www.w3schools.com/tags/tag_samp.asp So replacing <samp> with <code> does not make sense. And on some points, it is just not needed because it is correctly there. But <strong> highlights the words YES and NO and NEVER. That is how it should work, because of the "accentuation" of these words. <em> would be okay too, but it is a weaker accentuation than <strong>. I added a PR which changes the permissions.php language file. But i think it should be nessesary to check i up allover phpBB.
              Hide
              Permalink
              nickvergessen Joas Schilling added a comment -

              +1 for using strong

              Show
              nickvergessen Joas Schilling added a comment - +1 for using strong

                People

                • Assignee:
                  nickvergessen Joas Schilling
                  Reporter:
                  nickvergessen Joas Schilling
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development