Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11772

New topic notification triggered when editing an existing post with post-approval enabled

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.12-RC2
    • Fix Version/s: 3.1.0-b3
    • Component/s: Posting
    • Labels:
      None

      Description

      This is related to http://tracker.phpbb.com/browse/PHPBB3-10880

      Noticed on phpBB.com. I am a member of the Website Team group, which has "never" set for the "can post without approval" permission in the Announcements Forum. From another group, I also have permission to approve posts in that forum.

      Steps to reproduce:
      1) Edit old post in the announcements forum
      2) This now causes the post to become unapproved, due to PHPBB3-10880
      3) Approve the post

      This results in a new topic notification being sent to everyone watching that forum.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          EXreaction [X] why? We need to have this fixed in 3.1 aswell? https://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45167

          Show
          nickvergessen Joas Schilling added a comment - EXreaction [X] why? We need to have this fixed in 3.1 aswell? https://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45167
          Hide
          bantu Andreas Fischer added a comment -

          This is probably a won't fix for 3.0, though.

          Show
          bantu Andreas Fischer added a comment - This is probably a won't fix for 3.0, though.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment - - edited

          Read my previous comments. Fixing this would introduce significant complexity into the system and likely many other bugs.

          I do not believe that the amount of complexity required to fix this is worth introducing to fix this minor annoyance that few people will ever see.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - - edited Read my previous comments. Fixing this would introduce significant complexity into the system and likely many other bugs. I do not believe that the amount of complexity required to fix this is worth introducing to fix this minor annoyance that few people will ever see.
          Hide
          nickvergessen Joas Schilling added a comment -

          It happened quite a few times on phpbb.com already with the announcement forums...

          Show
          nickvergessen Joas Schilling added a comment - It happened quite a few times on phpbb.com already with the announcement forums...
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Anyone can feel free to propose a solution that resolves all of the issues I've mentioned. For the reasons I've mentioned, this is something I'm not interested in doing. I will gladly review something someone else does however if they want to try to fix it.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Anyone can feel free to propose a solution that resolves all of the issues I've mentioned. For the reasons I've mentioned, this is something I'm not interested in doing. I will gladly review something someone else does however if they want to try to fix it.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Marshalrusty Yuriy Rusko
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development