Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11761

Example.org no longer serves blank responses, failing functional tests

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.1.0-dev
    • 3.1.0-a1
    • Test Suite
    • None
    • PHP 5.2.3, MySQL 5.1.3, Firefox 3.6

    Description

      Problem:

      $upload->remote_upload('http://example.com/image.jpg');
      expects error EMPTY_REMOTE_DATA, but gets URL_NOT_FOUND instead

      Reproduce steps:

      1. Run functional tests

      Failing test:

      phpbb_functional_fileupload_remote_test -> test_non_existant

      Proposed solution:

      Make a blank file and serve it locally during the test, instead of hitting the http://example.org servers kindly provided by IANA.

      Other work that could be done:

      In my opinion, no phpbb test should hit an example.org/com/net (or any external) server since a local test server is already running during functional test.

      Attachments

        Activity

          People

            bantu Andreas Fischer [X] (Inactive)
            asperous asperous [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: