Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11706

getimagesize() should be called with @ to prevent PHP warning in remote avatar

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Labels:
      None

      Description

      getimagesize() will trigger a PHP warning if it is unable to access an avatar. This might happen if the image can't be reached, i.e. by a 404:
      [phpBB Debug] PHP Warning: in file [ROOT]/includes/avatar/driver/remote.php on line 96: getimagesize(https://www.phpbb.com/avatar/55502f40dc8b7c769880b10874abc9d0.jpg): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found

      In order to prevent this, the @ should be added back.

        Activity

        Hide
        imkingdavid David King added a comment -

        I'd prefer we do a file_exists check and handling it ourselves instead of hiding an error.

        Show
        imkingdavid David King added a comment - I'd prefer we do a file_exists check and handling it ourselves instead of hiding an error.
        Hide
        imkingdavid David King added a comment -

        After discussing in IRC, we determined that checking existence would take too long so going with the @ for now.

        Show
        imkingdavid David King added a comment - After discussing in IRC, we determined that checking existence would take too long so going with the @ for now.

          People

          • Assignee:
            imkingdavid David King
            Reporter:
            Marc Marc
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development