Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11666

POST_DELETED should refer to posts instead of messages

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-b2
    • Component/s: Language pack
    • Labels:
      None

      Description

      POST_DELETED and MESSAGE_DELETED are the same, this should be cleaned up after soft delete is merged

        Issue Links

          Activity

          Hide
          brunoais brunoais added a comment -

          You should pay better attention. Is it really the same in all languages?
          It may be the same in your language and in english but be different in other languages.

          Show
          brunoais brunoais added a comment - You should pay better attention. Is it really the same in all languages? It may be the same in your language and in english but be different in other languages.
          Hide
          galaxyAbstractor galaxyAbstractor [X] (Inactive) added a comment - - edited

          I agree with brunoais. Isn't there a difference between posts and messages? Posts are public ones in a topic while messages are private messages, and a quick search seems like that's how it's used.

          However, in posting.php:

          'POST_DELETED'				=> 'This message has been deleted successfully.',
          'POST_EDITED'				=> 'This message has been edited successfully.',
          'POST_EDITED_MOD'			=> 'This message has been edited successfully, but it will need to be approved by a moderator before it is publicly viewable.',
          

          Those are indeed the same, but I would think they are just translated wrong and ought to say post instead of message? Removing a post from the MPC says the post was removed, while removing a post from the topic view says the message has been deleted.

          Show
          galaxyAbstractor galaxyAbstractor [X] (Inactive) added a comment - - edited I agree with brunoais. Isn't there a difference between posts and messages? Posts are public ones in a topic while messages are private messages, and a quick search seems like that's how it's used. However, in posting.php: 'POST_DELETED' => 'This message has been deleted successfully.', 'POST_EDITED' => 'This message has been edited successfully.', 'POST_EDITED_MOD' => 'This message has been edited successfully, but it will need to be approved by a moderator before it is publicly viewable.', Those are indeed the same, but I would think they are just translated wrong and ought to say post instead of message? Removing a post from the MPC says the post was removed, while removing a post from the topic view says the message has been deleted.
          Hide
          nickvergessen Joas Schilling added a comment -

          Yeah basically we should just have a look and either remove one of them, or reword one

          Show
          nickvergessen Joas Schilling added a comment - Yeah basically we should just have a look and either remove one of them, or reword one
          Hide
          suheb suheb [X] (Inactive) added a comment -

          Removing MESSAGE_DELETED as it is not used.

          Show
          suheb suheb [X] (Inactive) added a comment - Removing MESSAGE_DELETED as it is not used.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Can't just remove one without updating all the usage.

          POST_DELETED would be the one to remove as MESSAGE_DELETED is more generic. You'd also need to search through the entire phpBB codebase and replace all instances of POST_DELETED with MESSAGE_DELETED.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Can't just remove one without updating all the usage. POST_DELETED would be the one to remove as MESSAGE_DELETED is more generic. You'd also need to search through the entire phpBB codebase and replace all instances of POST_DELETED with MESSAGE_DELETED.
          Hide
          suheb suheb [X] (Inactive) added a comment -

          Then I think it's better to reword one of the messages.. probably POST_DELETED.

          Show
          suheb suheb [X] (Inactive) added a comment - Then I think it's better to reword one of the messages.. probably POST_DELETED.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              EXreaction EXreaction [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development