Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11661

constants instead of table_prefix

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Won't Fix
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Build System
    • Labels:
      None

      Description

      I have watched that migrations using a mix of table_prefix and constants.

      Simultaneously can be deleted some unused entries in some files for $table_prefix.

      Search "table_prefix" in "\phpBB-3.1.0-dev\" (291 hits in 51 files)

        \phpBB-3.1.0-dev\includes\acp\acp_ban.php (1 hits)
      	Line 28: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_bots.php (1 hits)
      	Line 28: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_email.php (1 hits)
      	Line 28: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_groups.php (1 hits)
      	Line 28: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix, $file_uploads;
        \phpBB-3.1.0-dev\includes\acp\acp_inactive.php (1 hits)
      	Line 34: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_language.php (1 hits)
      	Line 34: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_profile.php (1 hits)
      	Line 31: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix;
        \phpBB-3.1.0-dev\includes\acp\acp_users.php (1 hits)
      	Line 34: 		global $phpbb_root_path, $phpbb_admin_path, $phpEx, $table_prefix, $file_uploads;
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_11_rc2.php (2 hits)
      	Line 26: 				$this->table_prefix . 'profile_fields' => array(
      	Line 37: 				$this->table_prefix . 'profile_fields' => array(
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_1_rc1.php (11 hits)
      	Line 21: 				$this->table_prefix . 'forums' => array(
      	Line 24: 				$this->table_prefix . 'sessions' => array(
      	Line 29: 				$this->table_prefix . 'groups' => array(
      	Line 34: 				$this->table_prefix . 'sessions' => array(
      	Line 37: 				$this->table_prefix . 'groups' => array(
      	Line 48: 				$this->table_prefix . 'forums' => array(
      	Line 51: 				$this->table_prefix . 'sessions' => array(
      	Line 56: 				$this->table_prefix . 'groups' => array(
      	Line 61: 				$this->table_prefix . 'sessions' => array(
      	Line 64: 				$this->table_prefix . 'groups' => array(
      	Line 83: 		$sql = 'UPDATE ' . $this->table_prefix . "topics
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_2_rc2.php (9 hits)
      	Line 26: 				$this->table_prefix . 'drafts' => array(
      	Line 29: 				$this->table_prefix . 'forums' => array(
      	Line 32: 				$this->table_prefix . 'posts' => array(
      	Line 35: 				$this->table_prefix . 'privmsgs' => array(
      	Line 38: 				$this->table_prefix . 'topics' => array(
      	Line 44: 				$this->table_prefix . 'sessions' => array(
      	Line 49: 				$this->table_prefix . 'sessions' => array(
      	Line 60: 				$this->table_prefix . 'sessions' => array(
      	Line 67: 				$this->table_prefix . 'sessions' => array(
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_3_rc1.php (5 hits)
      	Line 26: 				$this->table_prefix . 'styles_template' => array(
      	Line 30: 				$this->table_prefix . 'groups' => array(
      	Line 41: 				$this->table_prefix . 'styles_template' => array(
      	Line 45: 				$this->table_prefix . 'groups' => array(
      	Line 69: 		$sql = 'UPDATE ' . $this->table_prefix . 'modules
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_4.php (2 hits)
      	Line 36: 			$sql = 'UPDATE ' . $this->table_prefix . "log
      	Line 43: 			$sql = 'UPDATE ' . $this->table_prefix . "log
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_4_rc1.php (11 hits)
      	Line 26: 				$this->table_prefix . 'profile_fields' => array(
      	Line 31: 				$this->table_prefix . 'styles' => array(
      	Line 37: 				$this->table_prefix . 'styles_imageset' => array(
      	Line 40: 				$this->table_prefix . 'styles_imageset_data' => array(
      	Line 44: 				$this->table_prefix . 'styles_theme' => array(
      	Line 47: 				$this->table_prefix . 'styles_template' => array(
      	Line 50: 				$this->table_prefix . 'styles_template_data' => array(
      	Line 53: 				$this->table_prefix . 'forums' => array(
      	Line 56: 				$this->table_prefix . 'users' => array(
      	Line 67: 				$this->table_prefix . 'profile_fields' => array(
      	Line 118: 			$this->sql_query('UPDATE ' . $this->table_prefix . 'profile_fields SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . ' WHERE field_id = ' . $row['field_id'], $errored, $error_ary);
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_5_rc1.php (5 hits)
      	Line 26: 				$this->table_prefix . 'forums' => array(
      	Line 53: 				FROM ' . $this->table_prefix . 'users
      	Line 65: 				$this->sql_query('UPDATE ' . $this->table_prefix . 'users SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . ' WHERE user_id = ' . $row['user_id']);
      	Line 74: 		$sql = 'UPDATE ' . $this->table_prefix . "bots
      	Line 84: 			FROM ' . $this->table_prefix . 'acl_options
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_5_rc1part2.php (2 hits)
      	Line 26: 				$this->table_prefix . 'acl_options'		=> array('auth_option'),
      	Line 29: 				$this->table_prefix . 'acl_options'		=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_6_rc1.php (19 hits)
      	Line 26: 				$this->table_prefix . 'confirm' => array(
      	Line 29: 				$this->table_prefix . 'users' => array(
      	Line 34: 				$this->table_prefix . 'groups' => array(
      	Line 37: 				$this->table_prefix . 'privmsgs' => array(
      	Line 40: 				$this->table_prefix . 'reports' => array(
      	Line 43: 				$this->table_prefix . 'profile_fields'	=> array(
      	Line 46: 				$this->table_prefix . 'forums' => array(
      	Line 51: 				$this->table_prefix . 'users' => array(
      	Line 56: 				$this->table_prefix . 'reports' => array(
      	Line 60: 				$this->table_prefix . 'posts' => array(
      	Line 71: 				$this->table_prefix . 'confirm' => array(
      	Line 74: 				$this->table_prefix . 'users' => array(
      	Line 79: 				$this->table_prefix . 'groups' => array(
      	Line 82: 				$this->table_prefix . 'privmsgs' => array(
      	Line 85: 				$this->table_prefix . 'reports' => array(
      	Line 88: 				$this->table_prefix . 'profile_fields'	=> array(
      	Line 91: 				$this->table_prefix . 'forums' => array(
      	Line 96: 				$this->table_prefix . 'reports' => array(
      	Line 100: 				$this->table_prefix . 'posts' => array(
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_7_rc1.php (4 hits)
      	Line 26: 				$this->table_prefix . 'log' => array(
      	Line 31: 				$this->table_prefix . 'topics_track' => array(
      	Line 42: 				$this->table_prefix . 'log' => array(
      	Line 47: 				$this->table_prefix . 'topics_track' => array(
        \phpBB-3.1.0-dev\includes\db\migration\data\30x\3_0_9_rc1.php (6 hits)
      	Line 26: 				$this->table_prefix . 'login_attempts' => array(
      	Line 52: 				$this->table_prefix . 'bbcodes' => array(
      	Line 63: 				$this->table_prefix . 'login_attempts',
      	Line 111: 				$this->table_prefix . 'captcha_questions',
      	Line 112: 				$this->table_prefix . 'captcha_answers',
      	Line 113: 				$this->table_prefix . 'qa_confirm',
        \phpBB-3.1.0-dev\includes\db\migration\data\310\avatars.php (5 hits)
      	Line 26: 				$this->table_prefix . 'users'			=> array(
      	Line 29: 				$this->table_prefix . 'groups'			=> array(
      	Line 40: 				$this->table_prefix . 'users'			=> array(
      	Line 43: 				$this->table_prefix . 'groups'			=> array(
      	Line 60: 		$sql = 'UPDATE ' . $this->table_prefix . "modules
        \phpBB-3.1.0-dev\includes\db\migration\data\310\config_db_text.php (3 hits)
      	Line 14: 		return $this->db_tools->sql_table_exists($this->table_prefix . 'config_text');
      	Line 26: 				$this->table_prefix . 'config_text' => array(
      	Line 41: 				$this->table_prefix . 'config_text',
        \phpBB-3.1.0-dev\includes\db\migration\data\310\dev.php (9 hits)
      	Line 31: 				$this->table_prefix . 'groups'		=> array(
      	Line 34: 				$this->table_prefix . 'profile_fields'	=> array(
      	Line 37: 				$this->table_prefix . 'styles'		=> array(
      	Line 43: 				$this->table_prefix . 'reports'		=> array(
      	Line 50: 				$this->table_prefix . 'groups'		=> array(
      	Line 61: 				$this->table_prefix . 'groups'		=> array(
      	Line 64: 				$this->table_prefix . 'profile_fields'	=> array(
      	Line 67: 				$this->table_prefix . 'styles'		=> array(
      	Line 73: 				$this->table_prefix . 'reports'		=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\extensions.php (3 hits)
      	Line 14: 		return $this->db_tools->sql_table_exists($this->table_prefix . 'ext');
      	Line 26: 				$this->table_prefix . 'ext'	=> array(
      	Line 44: 				$this->table_prefix . 'ext',
        \phpBB-3.1.0-dev\includes\db\migration\data\310\notifications.php (10 hits)
      	Line 14: 		return $this->db_tools->sql_table_exists($this->table_prefix . 'notifications');
      	Line 26: 				$this->table_prefix . 'notification_types'	=> array(
      	Line 33: 				$this->table_prefix . 'notifications'		=> array(
      	Line 50: 				$this->table_prefix . 'user_notifications'	=> array(
      	Line 67: 				$this->table_prefix . 'notification_types',
      	Line 68: 				$this->table_prefix . 'notifications',
      	Line 69: 				$this->table_prefix . 'user_notifications',
      	Line 129: 					$this->sql_query('INSERT INTO ' . $this->table_prefix . 'user_notifications ' . $this->db->sql_build_array('INSERT', array(
      	Line 138: 						$this->sql_query('INSERT INTO ' . $this->table_prefix . 'user_notifications ' . $this->db->sql_build_array('INSERT', array(
      	Line 148: 						$this->sql_query('INSERT INTO ' . $this->table_prefix . 'user_notifications ' . $this->db->sql_build_array('INSERT', array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\notifications_schema_fix.php (8 hits)
      	Line 21: 				$this->table_prefix . 'notification_types',
      	Line 22: 				$this->table_prefix . 'notifications',
      	Line 25: 				$this->table_prefix . 'notification_types'	=> array(
      	Line 36: 				$this->table_prefix . 'notifications'		=> array(
      	Line 61: 				$this->table_prefix . 'notification_types',
      	Line 62: 				$this->table_prefix . 'notifications',
      	Line 65: 				$this->table_prefix . 'notification_types'	=> array(
      	Line 72: 				$this->table_prefix . 'notifications'		=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\reported_posts_display.php (3 hits)
      	Line 14: 		return $this->db_tools->sql_column_exists($this->table_prefix . 'reports', 'reported_post_enable_bbcode');
      	Line 26: 				$this->table_prefix . 'reports'		=> array(
      	Line 39: 				$this->table_prefix . 'reports'		=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\style_update_p1.php (9 hits)
      	Line 14: 		return !$this->db_tools->sql_table_exists($this->table_prefix . 'styles_imageset');
      	Line 26: 				$this->table_prefix . 'styles'		=> array(
      	Line 40: 				$this->table_prefix . 'styles'		=> array(
      	Line 78: 		if ($this->db_tools->sql_table_exists($this->table_prefix . 'styles_imageset'))
      	Line 81: 				FROM ' . STYLES_TABLE . ' s, ' . $this->table_prefix . 'styles_template t, ' . $this->table_prefix . 'styles_theme c, ' . $this->table_prefix . "styles_imageset i
      	Line 81: 				FROM ' . STYLES_TABLE . ' s, ' . $this->table_prefix . 'styles_template t, ' . $this->table_prefix . 'styles_theme c, ' . $this->table_prefix . "styles_imageset i
      	Line 81: 				FROM ' . STYLES_TABLE . ' s, ' . $this->table_prefix . 'styles_template t, ' . $this->table_prefix . 'styles_theme c, ' . $this->table_prefix . "styles_imageset i
      	Line 89: 				FROM ' . STYLES_TABLE . ' s, ' . $this->table_prefix . 'styles_template t, ' . $this->table_prefix . "stles_theme c
      	Line 89: 				FROM ' . STYLES_TABLE . ' s, ' . $this->table_prefix . 'styles_template t, ' . $this->table_prefix . "stles_theme c
        \phpBB-3.1.0-dev\includes\db\migration\data\310\style_update_p2.php (13 hits)
      	Line 14: 		return !$this->db_tools->sql_table_exists($this->table_prefix . 'styles_imageset');
      	Line 26: 				$this->table_prefix . 'styles'		=> array(
      	Line 34: 				$this->table_prefix . 'styles_imageset',
      	Line 35: 				$this->table_prefix . 'styles_imageset_data',
      	Line 36: 				$this->table_prefix . 'styles_template',
      	Line 37: 				$this->table_prefix . 'styles_template_data',
      	Line 38: 				$this->table_prefix . 'styles_theme',
      	Line 47: 				$this->table_prefix . 'styles'		=> array(
      	Line 55: 				$this->table_prefix . 'styles_imageset'		=> array(
      	Line 67: 				$this->table_prefix . 'styles_imageset_data'	=> array(
      	Line 82: 				$this->table_prefix . 'styles_template'		=> array(
      	Line 98: 				$this->table_prefix . 'styles_template_data'	=> array(
      	Line 111: 				$this->table_prefix . 'styles_theme'			=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\teampage.php (5 hits)
      	Line 14: 		return $this->db_tools->sql_table_exists($this->table_prefix . 'teampage');
      	Line 26: 				$this->table_prefix . 'teampage'	=> array(
      	Line 38: 				$this->table_prefix . 'groups'		=> array(
      	Line 49: 				$this->table_prefix . 'teampage',
      	Line 52: 				$this->table_prefix . 'groups'		=> array(
        \phpBB-3.1.0-dev\includes\db\migration\data\310\timezone.php (5 hits)
      	Line 14: 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_dst');
      	Line 26: 				$this->table_prefix . 'users'			=> array(
      	Line 44: 			FROM ' . $this->table_prefix . 'users
      	Line 50: 			$sql = 'UPDATE ' . $this->table_prefix . "users
      	Line 59: 		$sql = 'UPDATE ' . $this->table_prefix . "config
        \phpBB-3.1.0-dev\includes\db\migration\data\310\timezone_p2.php (3 hits)
      	Line 14: 		return !$this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_dst');
      	Line 26: 				$this->table_prefix . 'users'			=> array(
      	Line 37: 				$this->table_prefix . 'users'			=> array(
        \phpBB-3.1.0-dev\includes\db\migration\migration.php (5 hits)
      	Line 39: 	protected $table_prefix;
      	Line 61: 	* @param string $table_prefix
      	Line 63: 	public function __construct(phpbb_config $config, phpbb_db_driver $db, phpbb_db_tools $db_tools, $phpbb_root_path, $php_ext, $table_prefix)
      	Line 68: 		$this->table_prefix = $table_prefix;
      	Line 68: 		$this->table_prefix = $table_prefix;
        \phpBB-3.1.0-dev\includes\db\migrator.php (5 hits)
      	Line 35: 	protected $table_prefix;
      	Line 74: 	public function __construct(phpbb_config $config, phpbb_db_driver $db, phpbb_db_tools $db_tools, $migrations_table, $phpbb_root_path, $php_ext, $table_prefix, $tools)
      	Line 85: 		$this->table_prefix = $table_prefix;
      	Line 85: 		$this->table_prefix = $table_prefix;
      	Line 663: 		return new $name($this->config, $this->db, $this->db_tools, $this->phpbb_root_path, $this->php_ext, $this->table_prefix);
        \phpBB-3.1.0-dev\includes\functions_convert.php (1 hits)
      	Line 1208: 		$sql = 'SELECT * FROM ' . $convert->src_table_prefix . $convert->config_schema['table_name'];
      

        Attachments

          Activity

            People

            • Assignee:
              EXreaction EXreaction [X] (Inactive)
              Reporter:
              Kostenloses-Forum Kostenloses-Forum [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: