Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11635 Find all bypasses for generate_text_for_* and replace them with the call to that same function
  3. PHPBB3-11637

generate_text_for_display on search.php

          Details

          • Type: Sub-task
          • Status: Unverified Fix
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-dev
          • Fix Version/s: 3.1.0-a1
          • Component/s: None
          • Labels:
            None

            Description

            search.php:954
            until
            search.php:982

            Requires some analysis due to:
            search.php:960:get_context()

            That is used when $row['display_text_only'] is true.

              Activity

              Hide
              Permalink
              nickvergessen Joas Schilling added a comment -

              I'd just ignore the get_context() for now, as there are no BBCodes included there anyway.

              So just fix the

              					// Second parse bbcode here
              		 
              					if ($row['bbcode_bitfield'])
              		 
              					{
              		 
              						$bbcode->bbcode_second_pass($row['post_text'], $row['bbcode_uid'], $row['bbcode_bitfield']);
              		 
              					}
              		 
               
              		 
              					$row['post_text'] = bbcode_nl2br($row['post_text']);
              		 
              					$row['post_text'] = smiley_text($row['post_text']);

              Show
              nickvergessen Joas Schilling added a comment - I'd just ignore the get_context() for now, as there are no BBCodes included there anyway. So just fix the // Second parse bbcode here if ($row['bbcode_bitfield']) { $bbcode->bbcode_second_pass($row['post_text'], $row['bbcode_uid'], $row['bbcode_bitfield']); }   $row['post_text'] = bbcode_nl2br($row['post_text']); $row['post_text'] = smiley_text($row['post_text']);

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  brunoais brunoais
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development