Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11593

filter->compile_var_tags uses undefined variable

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Template Engine
    • Labels:
      None

      Description

      	private function compile_var_tags(&$text_blocks)
      	{
      		$text_blocks = $this->get_varref($text_blocks, $is_expr);

      $is_expr is not defined (it's a reference var sent to get_varref, which is then altered, but I am not sure whether this is allowed behavior or if it is supposed to be defined first).

        Activity

        Hide
        dhruv.goel92 Dhruv Goel added a comment -

        For consistency we should add $is_expr = null before the call?

        Show
        dhruv.goel92 Dhruv Goel added a comment - For consistency we should add $is_expr = null before the call?

          People

          • Assignee:
            dhruv.goel92 Dhruv Goel
            Reporter:
            EXreaction EXreaction [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development