Details
-
Improvement
-
Status: Unverified Fix (View Workflow)
-
Major
-
Resolution: Fixed
-
3.1.0-dev
-
None
Description
Currently we have a permission_phpbb.php file in the language dir with content as follows:
'acl_u_viewprofile' => array('lang' => 'Can view profiles, memberlist and online list', 'cat' => 'profile'),
|
'acl_u_chgname' => array('lang' => 'Can change username', 'cat' => 'profile'),
|
I think we sould split that of into another file and only keep the translations in the language dir:
New file: includes/permissions/phpbb.php
'acl_u_viewprofile' => array('lang' => 'ACL_U_VIEWPROFILE', 'cat' => 'profile'),
|
'acl_u_chgname' => array('lang' => 'ACL_U_CHANGENAME', 'cat' => 'profile'),
|
Translation file:
'ACL_U_VIEWPROFILE' => 'Can view profiles, memberlist and online list',
|
'ACL_U_CHANGENAME' => 'Can change username',
|
Should be quite easy to achieve and would make translating quite a bit easier and it just makes no sense to have the logic within the translation files
RFC: https://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=44285
Attachments
Issue Links
- caused
-
PHPBB3-12519 m_approve language update from soft delete patch got nucked by a merge conflict
-
- Closed
-