Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11582

Split permission logic from translations

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Language pack
    • Labels:
      None

      Description

      Currently we have a permission_phpbb.php file in the language dir with content as follows:

      	'acl_u_viewprofile'	=> array('lang' => 'Can view profiles, memberlist and online list', 'cat' => 'profile'),
      	'acl_u_chgname'		=> array('lang' => 'Can change username', 'cat' => 'profile'),

      I think we sould split that of into another file and only keep the translations in the language dir:
      New file: includes/permissions/phpbb.php

      	'acl_u_viewprofile'	=> array('lang' => 'ACL_U_VIEWPROFILE', 'cat' => 'profile'),
      	'acl_u_chgname'		=> array('lang' => 'ACL_U_CHANGENAME', 'cat' => 'profile'),

      Translation file:

      	'ACL_U_VIEWPROFILE'	=> 'Can view profiles, memberlist and online list',
      	'ACL_U_CHANGENAME'		=> 'Can change username',

      Should be quite easy to achieve and would make translating quite a bit easier and it just makes no sense to have the logic within the translation files

      RFC: https://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=44285

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development