Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11549

Resource locator does not find admin template files from extensions

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: ACP, Extensions, Styles
    • Labels:
      None

      Description

      This has been re-broken by the following commit:
      https://github.com/phpbb/phpbb3/commit/869e00a23b0400b9ad81c1130227cc4c29d6a38d
      [ticket/11362] Move phpbb_clean_path into a simple filesystem service

      We're back to geting this error:
      style resource locator: File for handle body does not exist. Could not find: ./../adm/style/acp_myextension.html, ./../adm/style/acp_myextension.html

      Of course, the extension file would be in the extensions directory... not in phpBB's core adm directory

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          Th problem is it now searches for adm/adm/style.
          This is caused by the fix of 10844 which prepends sets and extension path in the acp (adm), before setting the style path (adm/style).
          Setting the extension path is wrong in this case.

          Show
          nickvergessen Joas Schilling added a comment - Th problem is it now searches for adm/adm/style. This is caused by the fix of 10844 which prepends sets and extension path in the acp (adm), before setting the style path (adm/style). Setting the extension path is wrong in this case.
          Hide
          bantu Andreas Fischer added a comment -

          Please write tests first, then look for a solution.

          Show
          bantu Andreas Fischer added a comment - Please write tests first, then look for a solution.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Please don't forget link to your pull requests (even if they're in progress, just mark them needs work)

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Please don't forget link to your pull requests (even if they're in progress, just mark them needs work)

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development