Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11521

Missing language string when migration is invalid

    Details

      Description

      Something went wrong during the request and an exception was thrown. The changes made before the error occurred were reversed to the best of our abilities, but you should check the board for errors.
       
      MIGRATION_INVALID_DATA_CUSTOM_NOT_CALLABLE

        Activity

        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Do these really need to be translated? They are due to someone formatting their own code improperly, so users will not see this error.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Do these really need to be translated? They are due to someone formatting their own code improperly, so users will not see this error.
        Hide
        nickvergessen Joas Schilling added a comment -

        Users, that install broken extensions, and developers will and they should receive a decent message rather then a language key, all uppercase and using underscores.

        Show
        nickvergessen Joas Schilling added a comment - Users, that install broken extensions, and developers will and they should receive a decent message rather then a language key, all uppercase and using underscores.
        Hide
        aleha aleha added a comment -

        Also missing migrator language variables used in exception messages:

        MIGRATION_INVALID_DATA_MISSING_CONDITION
        MIGRATION_INVALID_DATA_MISSING_STEP
        MIGRATION_INVALID_DATA_UNKNOWN_TYPE
        MIGRATION_INVALID_DATA_UNDEFINED_TOOL
        MIGRATION_INVALID_DATA_UNDEFINED_METHOD

        Should these be documented?

        Show
        aleha aleha added a comment - Also missing migrator language variables used in exception messages: MIGRATION_INVALID_DATA_MISSING_CONDITION MIGRATION_INVALID_DATA_MISSING_STEP MIGRATION_INVALID_DATA_UNKNOWN_TYPE MIGRATION_INVALID_DATA_UNDEFINED_TOOL MIGRATION_INVALID_DATA_UNDEFINED_METHOD Should these be documented?
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        Are those translated before the user sees them?

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - Are those translated before the user sees them?
        Hide
        aleha aleha added a comment -

        No, but MIGRATION_INVALID_DATA_CUSTOM_NOT_CALLABLE isn't translated too.

        Show
        aleha aleha added a comment - No, but MIGRATION_INVALID_DATA_CUSTOM_NOT_CALLABLE isn't translated too.

          People

          • Assignee:
            nicofuma nicofuma
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development