Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11501

Fix "This test did not perform any assertions" message on some tests

          Details

          • Type: Bug
          • Status: Closed (View Workflow)
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-dev
          • Fix Version/s: 3.1.0-a1
          • Component/s: Test Suite
          • Labels:
            None

            Description

            5) phpbb_dbal_migrator_test::test_if
            		 
             
            		 
            This test did not perform any assertions

            uses fail() inside an if, instead of comparing the if statement

            6) phpbb_log_function_add_log_test::test_add_log_function_data
            		 
             
            		 
            This test did not perform any assertions
            		 
             
            		 
            7) phpbb_log_function_view_log_test::test_view_log_function_data
            		 
             
            		 
            This test did not perform any assertions

            methods are the data providers and should not be prefixed with test_*

              Attachments

                Activity

                  People

                  • Assignee:
                    nickvergessen Joas Schilling
                    Reporter:
                    nickvergessen Joas Schilling
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: