Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11487

replace creation of style and template classes with container calls

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Invalid
    • 3.1.0-dev
    • None
    • None
    • None

    Description

      There are several files (f.e. phpBB/includes/bbcode.php) that manually create instances of some style classes:

      $style_resource_locator = new phpbb_style_resource_locator();
      $style_path_provider = new phpbb_style_extension_path_provider($phpbb_extension_manager, new phpbb_style_path_provider());
      ...

      They should be replaced with calls to the container, where possible?

      (But keep in mind, that they sometimes need and have a different context, f.e. abusing style classes for email templates. There need to be two different objects then.)

      Attachments

        Activity

          People

            Marc Marc
            nickvergessen Joas Schilling
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: