Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11478

Daylight Savingtime changes old posts in time, too.

    Details

      Description

      The daylight saving time, if switched from "no" to "yes" doesn't skip an hour, instead it adds an hour to all post-times.

      For example:

      • if you wrote a reply yesterday on 3 p.m.
      • then switch dst on
      • the reply now appears with a post-time from 4 p.m.

      But that is simply no true. The real post time is still 3 p.m. and so the DST Switch should behave.

        Activity

        Hide
        bantu Andreas Fischer added a comment - - edited

        This is a direct consequence of using unix timestamps and offsets. This has been a design decision, so won't fix for 3.0 and probably 3.1.

        Show
        bantu Andreas Fischer added a comment - - edited This is a direct consequence of using unix timestamps and offsets. This has been a design decision, so won't fix for 3.0 and probably 3.1.
        Hide
        nickvergessen Joas Schilling added a comment -

        Should not be affecting 3.1, so a will-not-fix for me.

        Just tested: Timezone Berlin:

        for ($i = -4; $i <= 4; $i++)
        {
        	var_dump($user->format_date( 1364691300 + $i * 5 * 60));
        }

        Returns:

        string(24) "Sun Mar 31, 2013 1:35 am"
        string(24) "Sun Mar 31, 2013 1:40 am"
        string(24) "Sun Mar 31, 2013 1:45 am"
        string(24) "Sun Mar 31, 2013 1:50 am"
        string(24) "Sun Mar 31, 2013 1:55 am"
        string(24) "Sun Mar 31, 2013 3:00 am"
        string(24) "Sun Mar 31, 2013 3:05 am"
        string(24) "Sun Mar 31, 2013 3:10 am"
        string(24) "Sun Mar 31, 2013 3:15 am" 

        So its fixed in 3.1

        Show
        nickvergessen Joas Schilling added a comment - Should not be affecting 3.1, so a will-not-fix for me. Just tested: Timezone Berlin: for ($i = -4; $i <= 4; $i++) { var_dump($user->format_date( 1364691300 + $i * 5 * 60)); } Returns: string(24) "Sun Mar 31, 2013 1:35 am" string(24) "Sun Mar 31, 2013 1:40 am" string(24) "Sun Mar 31, 2013 1:45 am" string(24) "Sun Mar 31, 2013 1:50 am" string(24) "Sun Mar 31, 2013 1:55 am" string(24) "Sun Mar 31, 2013 3:00 am" string(24) "Sun Mar 31, 2013 3:05 am" string(24) "Sun Mar 31, 2013 3:10 am" string(24) "Sun Mar 31, 2013 3:15 am" So its fixed in 3.1
        Hide
        blackhawk.87 blackhawk.87 added a comment -

        And we can't transfer this to 3.0.12/.13 to fix it earlier?

        Show
        blackhawk.87 blackhawk.87 added a comment - And we can't transfer this to 3.0.12/.13 to fix it earlier?
        Hide
        nickvergessen Joas Schilling added a comment -

        as for summer to winter time:

        for ($i = -25; $i <= 4; $i++)
        {
        	var_dump($user->format_date(  1382838900 + $i * 5 * 60));
        	echo '<br />';
        }

        Result:

        string(24) "Sun Oct 27, 2013 1:50 am"
        string(24) "Sun Oct 27, 2013 1:55 am"
        string(24) "Sun Oct 27, 2013 2:00 am"
        string(24) "Sun Oct 27, 2013 2:05 am"
        string(24) "Sun Oct 27, 2013 2:10 am"
        string(24) "Sun Oct 27, 2013 2:15 am"
        string(24) "Sun Oct 27, 2013 2:20 am"
        string(24) "Sun Oct 27, 2013 2:25 am"
        string(24) "Sun Oct 27, 2013 2:30 am"
        string(24) "Sun Oct 27, 2013 2:35 am"
        string(24) "Sun Oct 27, 2013 2:40 am"
        string(24) "Sun Oct 27, 2013 2:45 am"
        string(24) "Sun Oct 27, 2013 2:50 am"
        string(24) "Sun Oct 27, 2013 2:55 am"
        string(24) "Sun Oct 27, 2013 2:00 am"
        string(24) "Sun Oct 27, 2013 2:05 am"
        string(24) "Sun Oct 27, 2013 2:10 am"
        string(24) "Sun Oct 27, 2013 2:15 am"
        string(24) "Sun Oct 27, 2013 2:20 am"
        string(24) "Sun Oct 27, 2013 2:25 am"
        string(24) "Sun Oct 27, 2013 2:30 am"
        string(24) "Sun Oct 27, 2013 2:35 am"
        string(24) "Sun Oct 27, 2013 2:40 am"
        string(24) "Sun Oct 27, 2013 2:45 am"
        string(24) "Sun Oct 27, 2013 2:50 am"
        string(24) "Sun Oct 27, 2013 2:55 am"
        string(24) "Sun Oct 27, 2013 3:00 am"
        string(24) "Sun Oct 27, 2013 3:05 am"
        string(24) "Sun Oct 27, 2013 3:10 am"
        string(24) "Sun Oct 27, 2013 3:15 am" 

        Someone could try to port the timezone fix back to 3.0 but it will require php 5.2+ because of the DateTime class that is used: http://www.php.net/manual/en/class.datetime.php

        Show
        nickvergessen Joas Schilling added a comment - as for summer to winter time: for ($i = -25; $i <= 4; $i++) { var_dump($user->format_date( 1382838900 + $i * 5 * 60)); echo '<br />'; } Result: string(24) "Sun Oct 27, 2013 1:50 am" string(24) "Sun Oct 27, 2013 1:55 am" string(24) "Sun Oct 27, 2013 2:00 am" string(24) "Sun Oct 27, 2013 2:05 am" string(24) "Sun Oct 27, 2013 2:10 am" string(24) "Sun Oct 27, 2013 2:15 am" string(24) "Sun Oct 27, 2013 2:20 am" string(24) "Sun Oct 27, 2013 2:25 am" string(24) "Sun Oct 27, 2013 2:30 am" string(24) "Sun Oct 27, 2013 2:35 am" string(24) "Sun Oct 27, 2013 2:40 am" string(24) "Sun Oct 27, 2013 2:45 am" string(24) "Sun Oct 27, 2013 2:50 am" string(24) "Sun Oct 27, 2013 2:55 am" string(24) "Sun Oct 27, 2013 2:00 am" string(24) "Sun Oct 27, 2013 2:05 am" string(24) "Sun Oct 27, 2013 2:10 am" string(24) "Sun Oct 27, 2013 2:15 am" string(24) "Sun Oct 27, 2013 2:20 am" string(24) "Sun Oct 27, 2013 2:25 am" string(24) "Sun Oct 27, 2013 2:30 am" string(24) "Sun Oct 27, 2013 2:35 am" string(24) "Sun Oct 27, 2013 2:40 am" string(24) "Sun Oct 27, 2013 2:45 am" string(24) "Sun Oct 27, 2013 2:50 am" string(24) "Sun Oct 27, 2013 2:55 am" string(24) "Sun Oct 27, 2013 3:00 am" string(24) "Sun Oct 27, 2013 3:05 am" string(24) "Sun Oct 27, 2013 3:10 am" string(24) "Sun Oct 27, 2013 3:15 am" Someone could try to port the timezone fix back to 3.0 but it will require php 5.2+ because of the DateTime class that is used: http://www.php.net/manual/en/class.datetime.php

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            blackhawk.87 blackhawk.87
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development